Skip to content

Implement incus image alias nested block#250

Merged
stgraber merged 3 commits intolxc:mainfrom
SpiffyEight77:feat/incus-image-alias
Jul 27, 2025
Merged

Implement incus image alias nested block#250
stgraber merged 3 commits intolxc:mainfrom
SpiffyEight77:feat/incus-image-alias

Conversation

@SpiffyEight77
Copy link
Contributor

@SpiffyEight77 SpiffyEight77 commented May 16, 2025 •
edited
Loading

Description

This pull request implements the incus_image_alias resource.

close #221

  • source code
  • document
  • test case

Example

Terraform Configuration

resource "incus_image" "img" {
  source_image = {
    remote = "images"
    name   = "alpine/edge"
  }

  alias {
    name        = "alpine"
    description = "Alpine Linux"
  }

  alias {
    name        = "alpine-edge"
    description = "Alpine Linux Edge"
  }
}

@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch 6 times, most recently from d8aaeb1 to 6015eeb Compare May 19, 2025 09:54
@SpiffyEight77 SpiffyEight77 marked this pull request as ready for review May 19, 2025 10:34
@SpiffyEight77 SpiffyEight77 marked this pull request as draft May 19, 2025 10:43
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch from 6015eeb to 1811a53 Compare May 20, 2025 15:19
@stgraber
Copy link
Member

stgraber commented May 20, 2025

@SpiffyEight77 how's this one going?

@SpiffyEight77
Copy link
Contributor Author

SpiffyEight77 commented May 20, 2025

Hi @stgraber !
I'll need two more days for testing. I modified the sync state logic for image resources.

@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch 2 times, most recently from 56c6a7f to c6aa483 Compare May 26, 2025 15:14
@SpiffyEight77 SpiffyEight77 changed the title Implement incus_image_alias resource Implement incus image alias nested block May 28, 2025
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch 7 times, most recently from e8c0967 to 9eb4e1a Compare May 30, 2025 16:35
@SpiffyEight77 SpiffyEight77 marked this pull request as ready for review May 30, 2025 16:44
@stgraber
Copy link
Member

stgraber commented May 31, 2025

@maveonair want to review this one?

maveonair
maveonair requested changes Jun 9, 2025
View reviewed changes
Copy link
Member

@maveonair maveonair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SpiffyEight77 very well done! Please have a look at my comments.

@SpiffyEight77
Copy link
Contributor Author

SpiffyEight77 commented Jun 10, 2025

Thanks @maveonair and @stgraber for confirming! I'll refactor to remove the aliases later this week.

@SpiffyEight77 SpiffyEight77 marked this pull request as draft June 15, 2025 10:06
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch 2 times, most recently from eb8993a to 28fb203 Compare June 16, 2025 15:23
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch 2 times, most recently from b2897ad to a3e2462 Compare June 23, 2025 03:25
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch from a3e2462 to 741003d Compare June 23, 2025 07:07
@maveonair
Copy link
Member

maveonair commented Jun 26, 2025

@SpiffyEight77 do you need any support on this PR?

@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch 8 times, most recently from 5f3ff1c to 831c725 Compare June 29, 2025 03:48
@SpiffyEight77
image: Implement incus image alias nested block
ac7d407 
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
@SpiffyEight77
docs: Implement incus image alias nested block
8d5d04e 
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch from 831c725 to 577cfbe Compare June 29, 2025 04:04
@SpiffyEight77 SpiffyEight77 marked this pull request as ready for review June 29, 2025 04:12
@SpiffyEight77 SpiffyEight77 requested a review from maveonair June 29, 2025 04:16
@SpiffyEight77
Copy link
Contributor Author

SpiffyEight77 commented Jun 29, 2025 •
edited
Loading

@maveonair
Thanks, the PR is ready for review and I think we need to re-run the failed acceptance tests.

@SpiffyEight77
test: Implement incus image alias nested block
421cfae 
Signed-off-by: Ruihua Wen <spiffyeight77@gmail.com>
@SpiffyEight77 SpiffyEight77 force-pushed the feat/incus-image-alias branch from 577cfbe to 421cfae Compare June 29, 2025 04:27
@stgraber stgraber merged commit da2c14f into lxc:main Jul 27, 2025
22 of 34 checks passed
@stgraber
Copy link
Member

stgraber commented Jul 27, 2025

Sorry for the wait, we had some issues with Incus itself that needed fixing before we could get the tests to pass. All good now.

@SpiffyEight77 SpiffyEight77 deleted the feat/incus-image-alias branch July 29, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stgraber stgraber stgraber left review comments

@maveonair maveonair maveonair approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement an incus_image_alias resource

3 participants

@SpiffyEight77 @stgraber @maveonair